Skip to content

remove streams#254

Merged
boulter merged 1 commit intomasterfrom
no-streams
Nov 13, 2018
Merged

remove streams#254
boulter merged 1 commit intomasterfrom
no-streams

Conversation

@boulter
Copy link
Contributor

@boulter boulter commented Nov 12, 2018

Do not use streams here to work around a potential bytecode compatibility issue with Java 9 through 11 while we continue to release using a Java 8 compiler.

For #228

@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #254 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #254      +/-   ##
============================================
+ Coverage     71.84%   71.88%   +0.03%     
- Complexity     1402     1404       +2     
============================================
  Files           220      220              
  Lines          4412     4417       +5     
  Branches        700      703       +3     
============================================
+ Hits           3170     3175       +5     
  Misses         1002     1002              
  Partials        240      240
Impacted Files Coverage Δ Complexity Δ
...in/java/com/hubspot/jinjava/lib/filter/Filter.java 100% <100%> (ø) 4 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c490dc3...c9a223e. Read the comment docs.

@boulter boulter merged commit 4294fd9 into master Nov 13, 2018
@boulter boulter deleted the no-streams branch November 13, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants