Add millis precision to unixtimestamp function#399
Merged
Conversation
boulter
changed the title
mattcoley
approved these changes
Feb 12, 2020
boulter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We claimed to provide microsecond formatting options in the
unixtimestampfilter, but we were rounding to seconds. Millis are now in there. Adding micros would change the return value and break compatibility.Separately, the date/time formatter has been updated to return seconds in microseconds but will still be rounded to micros if the source of the date the source is millis precision such as the
unixtimestampfunction.I also fixed the
unixtimestampto use the value ofnow()when passed no arguments.