Track correct path for multiple level of Extends inheritance#667
Merged
Track correct path for multiple level of Extends inheritance#667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're not tracking the currentPath correctly when dealing with multiple levels of inheritance via
extendstags, which is leading to incorrect relative path resolution.Prior to this PR, the test example: https://github.com/HubSpot/jinjava/pull/667/files#diff-2970b2d908f3ae9b6918c9b1bd9c7b678a92a8a054cb2c9bded5817bd4a41a9eR1
would resolve
./hello.htmlto/tags/extendstag/relative/hello.htmlbecause it was incorrectly usingtags/extendstag/relative/nested-relative-extends-2.jinjaas the current path.