Move MAX_HISTORY counter increment into cleanPeriod in 1.3.x
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jengmicah
changed the title
MAX_HISTORY counter increment into cleanPeriodMAX_HISTORY counter increment into cleanPeriod in 1.3.x
jaredstehler
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The deleted-log-file metrics were added to 1.3.x in #1
The
maxHistorymetric is currently incremented incheckAndDeleteFile(), which is also invoked bycapTotalSize()(a change from 1.2.x to 1.3.x).This means that hitting the total size cap will increment both
totalSizeCapandmaxHistorycounters.What
This PR moves the
maxHistoryupdate out ofcheckAndDeleteFile()and intocleanPeriod(), where max history is checked.I'll also add this to 1.4.x in another PR.
cc @jaredstehler