Add model for Slack member_left_channel event#175
Merged
zmarushchak-hs merged 3 commits intomasterfrom Jun 18, 2020
Merged
Conversation
omotnyk
reviewed
Jun 18, 2020
| @Immutable | ||
| @HubSpotStyle | ||
| @JsonNaming(SnakeCaseStrategy.class) | ||
| @JsonDeserialize(as = SlackMemberLeftChannelEvent.class) |
Contributor
There was a problem hiding this comment.
I mean, I see that it's copied from other events but still, why do we need this?
Contributor
There was a problem hiding this comment.
Okay, I see. Parent interface has custom deserializer.
omotnyk
approved these changes
Jun 18, 2020
omotnyk
suggested changes
Jun 18, 2020
Contributor
omotnyk
left a comment
omotnyk
left a comment
There was a problem hiding this comment.
Can we add tests for this event in EventDeserializerTest?
omotnyk
reviewed
Jun 18, 2020
omotnyk
approved these changes
Jun 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to deal with member_left_channel Slack event. Added model for it.