Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple band-aid PR that begins to tackle the new
EVENT_CALLBACKpayload. Slack has changed how they deliver events as webhooks. Historically, they would set the type in the top level, and you'd have to deserialize the "event" object depending on what you had.Now, they outside envelope is much more homogenous (
EVENT_CALLBACKas the uniform type). However, this means we have to support both, and adding the new support without breaking the old support is painful. This PR doesn't tackle that problem since it's MUCH larger than this, it simply adjusts the way messages are deserialized to include important information so we can still operate over bot messages.