Added support of channel_shared event#217
Merged
leonidhladii merged 2 commits intomasterfrom Mar 26, 2021
Merged
Conversation
Contributor
zmarushchak-hs
left a comment
zmarushchak-hs
left a comment
There was a problem hiding this comment.
Please see my comments inlined.
|
|
||
| @Value.Immutable | ||
| @HubSpotStyle | ||
| @JsonNaming(SnakeCaseStrategy.class) |
Contributor
There was a problem hiding this comment.
Please correct me if I'm wrong, but I think we don't need @JsonNaming(SnakeCaseStrategy.class) if we have @JsonProperty("connected_team_id") set for the field.
| "authed_users": [ | ||
| "UBRFHDFGA" | ||
| ] | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Missing channel_shared event.
Description
Added support of channel shared event to
SlackEventType