Merged
Conversation
added 4 commits
August 9, 2021 17:38
…eduledMessage, chat.scheduledMessages.list)
zmarushchak-hs
approved these changes
Aug 11, 2021
Contributor
zmarushchak-hs
left a comment
zmarushchak-hs
left a comment
There was a problem hiding this comment.
Just a few nits. Please feel free to merge after they are addressed.
|
|
||
| String getScheduledMessageId(); | ||
|
|
||
| @JsonProperty("as_user") |
Contributor
There was a problem hiding this comment.
Do we need this? Looks like the argument looks the same.
Contributor
Author
There was a problem hiding this comment.
Yes, it's fully the same, I'll update and fix it. Thank you.
|
|
||
| @Immutable | ||
| @HubSpotStyle | ||
| @JsonNaming(SnakeCaseStrategy.class) |
Contributor
Author
There was a problem hiding this comment.
Right there is no need for that, because there is no response metadata in this endpoint's response. I'll update and fix it.
… ChatDeleteScheduledMessageParamsIF interface, delete unnecessary @JsonNaming(SnakeCaseStrategy.class) from ChatScheduledMessagesListParamsIF interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds schedule message endpoints and unit test for them.
adds long in ReflectionBasedFieldPresenceTest's numeric parameter type checking.