Add subtype for conversations-select input#253
Merged
zmarushchak-hs merged 3 commits intomasterfrom Nov 11, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fields for
ConversationsSelectMenumodel to receive channel id in the View Submission. Also added subtype ofViewInputtype for the conversations-select input object unmarshalling.Context: when the user selects the channel from Conversations list on the model, Slack sends are
conversations-selectobject in the view submissionstatefield (please see example below). In order to get the select channel, we need to have a corresponding model.