Skip to content

Normalize some of blocks' presentational data#266

Merged
omotnyk merged 1 commit intomasterfrom
normalize_block_data_before_validation
Feb 18, 2022
Merged

Normalize some of blocks' presentational data#266
omotnyk merged 1 commit intomasterfrom
normalize_block_data_before_validation

Conversation

@omotnyk
Copy link
Copy Markdown
Contributor

@omotnyk omotnyk commented Feb 11, 2022

Same as #258 but for some of the BlockKit models.

@leonidhladii
Copy link
Copy Markdown
Contributor

@omotnyk looks good at all.
Do we plan to add the same validation stuff to External...Menu, Date/Time pickers, OverflowMenu?

@omotnyk
Copy link
Copy Markdown
Contributor Author

omotnyk commented Feb 11, 2022

@leonidhladii Yeah, but I didn't want to spend time normalizing all the input data that we don't use at this point.

Still, I realized that we at least use ExternalSelectMenu so I'll add its normalization as well. Thanks!

@omotnyk
Copy link
Copy Markdown
Contributor Author

omotnyk commented Feb 11, 2022

@leonidhladii Getting back to this, I don't think there is much we can normalize in ExternalSelectMenu. There is a placeholder but don't really use it in a way that can cause issues with its length.

Do you think we can merge this PR?

@leonidhladii
Copy link
Copy Markdown
Contributor

Works for me, good job 🚀

@omotnyk omotnyk merged commit 8f814d5 into master Feb 18, 2022
@omotnyk omotnyk deleted the normalize_block_data_before_validation branch February 18, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants