Add getStringValue method to BlockKit inputs#267
Merged
zmarushchak-hs merged 2 commits intomasterfrom Feb 17, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, each input type has its own type for the included value it is needed to handle each input separately. It is not convenient when handling a collection of inputs (consider situation when different BlockKit inputs are submitted for the same view). This PR adds a getter to the ViewInput interface to make values extraction more universal (return a String value).
I decided that converting to String DatePicker and multiple checkboxes inputs makes no sense and I think it is OK to handle them as a special case.