Merged
Conversation
nliutyi-hs
added a commit
that referenced
this pull request
Nov 28, 2022
This reverts commit 53221e2.
nliutyi-hs
added a commit
that referenced
this pull request
Nov 28, 2022
This reverts commit 53221e2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We broke the serialization of
TextStyleIFin #304 because ifOptionalis empty we pass"code": nullto Slack and it returns us response like this:We have to exclude the fields completely if
Optionalis empty or make them default tofalse. I think the latter option makes way more sense sinceOptional<Boolean>itself doesn't make a lot of sense and only complicates the interaction the code.