Skip to content

Remove deprecated method SlackEvent::toDetailedEvent(), upgrade basepom, apply prettier formatting#323

Merged
jaredstehler merged 4 commits intomasterfrom
js-upgrade-basepom
Mar 13, 2024
Merged

Remove deprecated method SlackEvent::toDetailedEvent(), upgrade basepom, apply prettier formatting#323
jaredstehler merged 4 commits intomasterfrom
js-upgrade-basepom

Conversation

@jaredstehler
Copy link
Copy Markdown
Contributor

@jaredstehler jaredstehler commented Mar 13, 2024

Upgrades basepom to 59.5. This includes an update of immutables, which results in the following compilation error:

[ERROR] /src/oss/slack-client/slack-base/src/main/java/com/hubspot/slack/client/models/events/SlackEvent.java:[15,36] Method 'toDetailedEvent' cannot have own generic type parameters. Attribute accessors can only use enclosing type's type variables

Since this method was already deprecated, it is removed in this PR.

This also updates the target JDK from 8 to 11.

I will release 1.13 beforehand, and merge this PR into 1.14-SNAPSHOT.

@jaredstehler jaredstehler merged commit c6a41a8 into master Mar 13, 2024
@jaredstehler jaredstehler deleted the js-upgrade-basepom branch March 13, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant