fix: touchend.prevent blocked all key taps after diacritic popup#181
fix: touchend.prevent blocked all key taps after diacritic popup#181
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
After using the diacritic long-press popup on mobile, ALL subsequent key taps stopped working — even on different pages. The keyboard became completely unresponsive.
Root Cause
@touchend.preventonKeyboardKey.vueunconditionally calledpreventDefault()on every key's touchend event. This prevented the browser from generating the subsequentclickevent. SincehandleClickis where key presses are emitted, no letters could be typed after any touch interaction.Fix
Changed
@touchend.prevent="handleTouchEnd"to@touchend="handleTouchEnd"and movede.preventDefault()inside the handler, only calling it when the popup was actually shown and used. Normal key taps now complete the full touch→click cycle.Test plan