Skip to content

Conversation

@CravateRouge
Copy link

Purpose

Enhancement:

  1. with this PR, "menu main" with children can also have a clickable link:
menus:
 main:
  - name: Services
   hasChildren: yes
   url: /services
  - name: Audit
   parent: Services
  url: /services/audit

Fix

  1. if "menu main" has no "url" it will default to href='' instead of href='/' (better to do logical testing with a $url="" in templating code)
  2. if only fragment provided as url: "#about" it is now associated to home page and not relative page, as intended before but the concatenating was forgot.

fragment as `url: "#about"` are now associated to home page and menu main with children can also have link
@netlify
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for academic-demo canceled.

Name Link
🔨 Latest commit 49f51cf
🔍 Latest deploy log https://app.netlify.com/sites/academic-demo/deploys/67e64e31ee1d0a0008f916d1

@github-actions
Copy link
Contributor

This PR is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If you feel that the PR is still relevant in the latest release, consider making the PR easier to review and finding developers to help review the PR.

Please be mindful that although we encourage PRs, we cannot expand the scope of the project in every possible direction. There will be requests that don't make the roadmap.

This PR will automatically close soon if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 28, 2025
@github-actions github-actions bot closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant