Update readme file & Docker Setup#12
Conversation
|
@matthib you can prefix the PR title with |
roschaefer
left a comment
There was a problem hiding this comment.
I like it, you're going in the right direction @matthib - please add a separate #Installation with Docker section and keep the verbosity low. E.g. you can remove redundancy by showing the terminal output instead of a text paragraph explaining the command which the user should put in the terminal.
|
|
||
| **PREREQUESITES** | ||
|
|
||
| Before starting the installation you need to make sure you have the following tools installed: |
There was a problem hiding this comment.
Slightly verbose. I would put this paragraph in one sentence and use link formatting. Example:
"""
Make sure that you have a recent version of node, yarn, EmberJS, ruby, Redis and postgresql installed before you proceed. E.g. we have the following versions:
$ node --version
v10.4.1
$ yarn --version
1.7.0
$ ember --version
ember-cli: 3.1.4
node: 10.4.1
os: linux x64"""
source: https://github.com/roschaefer/rundfunk-mitbestimmen/edit/master/README.md
| @@ -0,0 +1,16 @@ | |||
| FROM node:11 | |||
There was a problem hiding this comment.
| FROM node:11 | |
| FROM node:10-alpine |
Because of
- Long term support
- We can share the docker base image with
Nitro-BackendandNitro-Web
There was a problem hiding this comment.
Unfortunately the alpine version of node doesn't work with the dependencies we have. We use the package "sharp", which needs several build tools that node-alpine doesn't include. Manually installing those requirements in the Dockerfile for node-alpine unfortunately didn't work out, so I was forced to use the full node image.
Should we downgrade to version 10 of node though?
There was a problem hiding this comment.
ewwww
OK, let's just keep it for now
…rate nodemon live reload
…g port number Co-Authored-By: matthib <matthi@bonn-boehms.de>
|
@matthib actually we can merge this PR, why is it work-in-progress? I just // 20190123230807
// http://localhost:1337/
{
"error": "unauthorised"
} |
|
For testing mail delivery during development, I suggest to use mailhog and configure SMTP settings in |
|
Here could be a solution for using sharp with alpine. |
@roschaefer The database part is still missing. But you are right, the system works like this right out of the box. |
@appinteractive Thanks for the link! Tried those solutions before and unfortunately they didn't work out. I still get errors when trying to build sharp in the npm install process. I'll keep looking though, maybe there is a solution that works fine. |
|
@matthib well then let's create another ticket |
Updated for the README.md documentation and a first basic version of a dockerized API server.
Currently Work in Progress!