Fix relative paths for uploads#34
Merged
roschaefer merged 1 commit intomasterfrom Mar 29, 2019
Merged
Conversation
…ving profile images works with any user running the node server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix relative paths for uploads, so uploading and serving profile images works with any user running the node server.
When deploying the current code and running it with my user via pm2, I had the problem that the uploaded files couldn't be accessed an served.
In order to fix this, I had to change the paths, taking the current directory into account. See also https://expressjs.com/en/starter/static-files.html (last paragraph).
This is the code that I changed on the server to make it work. For consistency of course I also update the git repo with the code.