Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

Fix follow and shout status#201

Merged
appinteractive merged 21 commits intomasterfrom
distinct-shouts-and-follows
Mar 8, 2019
Merged

Fix follow and shout status#201
appinteractive merged 21 commits intomasterfrom
distinct-shouts-and-follows

Conversation

@appinteractive
Copy link
Copy Markdown
Member

@appinteractive appinteractive commented Mar 3, 2019

Fix

Relates to

Human-Connection/Nitro-Web#213

Todos

  • introduce new (un)shout and (un)follow mutations
  • disabled shouting of own content
  • disabled following of itself
  • write tests
  • add date to shout

Copy link
Copy Markdown
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appinteractive nice job, but I strongly suggest to add tests for the queries. It won't be a big deal. There are great examples in the code base already, e.g. look at that PR by @Tirokk and @mattwr18 : #195

Comment thread src/schema.graphql
@Tirokk
Copy link
Copy Markdown
Member

Tirokk commented Mar 5, 2019

There a some general errors, as far I can see @appinteractive @roschaefer @mattwr18 :

  1. If I login, no matter if as user etc., the news feed is empty, see first screenshot.
  2. If I go on my profile an error occurs, see second screenshot.

I’m at Frontend and Backend on branch distinct-shouts-and-follows.
I make the usual seed.

bildschirmfoto 2019-03-05 um 09 34 38

bildschirmfoto 2019-03-05 um 09 34 54

@appinteractive
Copy link
Copy Markdown
Member Author

appinteractive commented Mar 5, 2019

@Tirokk could you try to run yarn db:reset && yarn db:seed once and refresh?
And thanks! You found an issue 👍 Should be fixed now.

@appinteractive
Copy link
Copy Markdown
Member Author

@roschaefer Backend Tests are green! 🥳

@appinteractive appinteractive changed the title [WIP] Fix follow and shout status Fix follow and shout status Mar 5, 2019
@Tirokk
Copy link
Copy Markdown
Member

Tirokk commented Mar 6, 2019

Do I have to run with yarn dev or yarn dev:styleguide @appinteractive ?

@appinteractive
Copy link
Copy Markdown
Member Author

appinteractive commented Mar 6, 2019

Do I have to run with yarn dev or yarn dev:styleguide @appinteractive ?

yarn dev but you will need to update both branches and run yarn install before once.

@Lulalaby
Copy link
Copy Markdown

Lulalaby commented Mar 7, 2019

Is it still WIP?

@appinteractive
Copy link
Copy Markdown
Member Author

Build is failing 😞

@appinteractive
Copy link
Copy Markdown
Member Author

Also we need the date of the shout for sorting

@Lulalaby
Copy link
Copy Markdown

Lulalaby commented Mar 7, 2019

Build is failing 😞

I think: just rerun
The command "curl -L https://github.com/docker/compose/releases/download/${DOCKER_COMPOSE_VERSION}/docker-compose-`uname -s-uname -m` > docker-compose" failed and exited with 56 during .

@appinteractive appinteractive changed the title Fix follow and shout status [WIP] Fix follow and shout status Mar 8, 2019
@pr-triage pr-triage Bot removed the PR: unreviewed label Mar 8, 2019
@appinteractive
Copy link
Copy Markdown
Member Author

Seems it was just the mismatch with master.

@appinteractive appinteractive changed the title [WIP] Fix follow and shout status Fix follow and shout status Mar 8, 2019
@appinteractive appinteractive merged commit e6d0948 into master Mar 8, 2019
@appinteractive appinteractive deleted the distinct-shouts-and-follows branch March 8, 2019 14:33
@appinteractive appinteractive added this to the Fortuna milestone Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants