add in-repo pr-review skill and align test fast loop docs#101
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
HumanBean17
changed the title
8 tasks
HumanBean17
added a commit
that referenced
this pull request
May 13, 2026
whole effort landed: PR-1 (#100), PR-2 (#101), PR-3 (#102). per .cursor/rules/agent-workflow.mdc, move propose / plan into the completed/ trees once the *whole* effort is landed — not after each PR. - propose/TEST-SUITE-FAST-LOOP-PROPOSE.md → propose/completed/ (status header flipped to "locked — implemented across PR-1..PR-3") - plans/PLAN-TEST-SUITE-FAST-LOOP.md → plans/completed/ (status flipped to "completed"; tracking footer notes merged PRs and the PR-1 → PR-2 → PR-3 landing-order divergence) - update inbound links: - tests/README.md iteration-subset paragraph: point at the completed/ paths; drop the now-stale "once the merge gate from PR-3 exists" wording since it now exists. - .cursor/skills/plan-prompts/SKILL.md: bump the two cross-refs in the "Tests to run (iteration loop) — required subsection". - automation/cursor_propose_only/README.md: swap the autopilot example --proposal arg to TIER2-INCREMENTAL-REBUILD-PROPOSE.md so the copy-pasteable command keeps pointing at an active propose. Co-authored-by: Cursor <cursoragent@cursor.com>
HumanBean17
added a commit
that referenced
this pull request
May 13, 2026
…loop) (#102) * add github actions test workflow and update merge-gate doc (PR-3 fast loop) implements PR-3 from plans/PLAN-TEST-SUITE-FAST-LOOP.md. - .github/workflows/test.yml: pytest tests -v on pull_request and on push to master; python 3.11; pip install -r requirements.txt + pip install -e . (registers the java-codebase-rag cli entry point for shutil.which checks in tests/test_java_codebase_rag_cli.py); JAVA_CODEBASE_RAG_RUN_HEAVY=0. - workflow + job both named "test" so the check-context string is deterministic (verify with `gh pr checks` before applying branch protection per plan resolved-decisions table). - tests/README.md: tighten the "Merge gate (mechanical)" paragraph to point at the now-real workflow file; drop the "until that lands" hedge; document `enforce_admins: false` break-glass policy. tier tables, consumer matrix, and iteration-subset paragraph untouched (PR-1 / PR-2 own those). note: PR-1 (#100) and PR-2 (#101) merged before PR-3, contrary to the plan's stated PR-3 → PR-1 → PR-2 order. branch protection still requires the dummy-failure validation step before the gh api call that locks master. Co-authored-by: Cursor <cursoragent@cursor.com> * fix doc: actual check-context is "test" not "test / test" verified with `gh pr checks 102` after the first workflow run on this branch — github collapses the context when workflow name and job name match. update tests/README.md merge-gate paragraph to use the verbatim string so the gh-api branch-protection call in the PR body works. Co-authored-by: Cursor <cursoragent@cursor.com> * move test-suite-fast-loop propose + plan to completed/ whole effort landed: PR-1 (#100), PR-2 (#101), PR-3 (#102). per .cursor/rules/agent-workflow.mdc, move propose / plan into the completed/ trees once the *whole* effort is landed — not after each PR. - propose/TEST-SUITE-FAST-LOOP-PROPOSE.md → propose/completed/ (status header flipped to "locked — implemented across PR-1..PR-3") - plans/PLAN-TEST-SUITE-FAST-LOOP.md → plans/completed/ (status flipped to "completed"; tracking footer notes merged PRs and the PR-1 → PR-2 → PR-3 landing-order divergence) - update inbound links: - tests/README.md iteration-subset paragraph: point at the completed/ paths; drop the now-stale "once the merge gate from PR-3 exists" wording since it now exists. - .cursor/skills/plan-prompts/SKILL.md: bump the two cross-refs in the "Tests to run (iteration loop) — required subsection". - automation/cursor_propose_only/README.md: swap the autopilot example --proposal arg to TIER2-INCREMENTAL-REBUILD-PROPOSE.md so the copy-pasteable command keeps pointing at an active propose. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cursor/skills/pr-review/SKILL.md— PR checklist skill (subset: pastedpytest+ exit code; full suite: green Actions URL after PR-3). Committed in-repo so it shows in review diffs alongsideplan-prompts.plan-prompts: iteration contract references the repopr-reviewpath (no longer described as user-only).plans/PLAN-TEST-SUITE-FAST-LOOP.md,propose/TEST-SUITE-FAST-LOOP-PROPOSE.md,tests/README.md— both skills canonical under.cursor/skills/; optional copy to~/.cursor/skills/if Cursor only loads personal skills.cursor-pr-review→pr-reviewin completed plans/proposes anddocs/skills/java-codebase-explore.md; MCP completed-plan bullets treatpr-reviewas in-repo.Scope
Documentation and Cursor project skills only (no production
*.pyoutsidetests/).Tests
Not run (markdown /
SKILL.mdcopy only).