feat: filter frame vocabulary renames (PR-FRAME-1)#131
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Implements PR-FRAME-1 from
plans/PLAN-MCP-FILTER-FRAME.md(vocabulary audit / Appendix A inpropose/MCP-FILTER-FRAME-PROPOSE.md).NodeFilter.client_method; the existinghttp_methodfield applies to bothrouteandclientkinds (16 NodeFilter fields)._NODEFILTER_APPLICABLE_FIELDS,_node_matches_filter(client branch), andfind_v2clientlist_clients(method=...)wiring.docs/AGENT-GUIDE.md: field table,http_methodcross-kind note,source_layervsrole,target_servicevsmicroservice.tests/test_mcp_v2.pyfor cross-kindhttp_methodbehavior and rejection of the old field name.Out of scope (per plan)
PR-FRAME-2/3 items (wildcards,
describe(fqn=…), tool-description refresh, fail-loud counters,kuzu_queries.pyrename of internalmethod=, ontology bump).Manual evidence
.venv/bin/ruff check . .venv/bin/python -m pytest tests -qResult: 414 passed, 10 skipped (full
tests/run).Sentinel:
client_methodabsent frommcp_v2.py,server.py,docs/AGENT-GUIDE.md.Test count
Five tests in scope for this PR:
test_http_method_field_applies_to_route_kind,test_http_method_field_applies_to_client_kind,test_http_method_field_inapplicable_to_symbol,test_nodefilter_rejects_old_client_method_field, plus existingtest_nodefilter_applicability_table_covers_all_fields.Made with Cursor