Skip to content

feat: filter frame vocabulary renames (PR-FRAME-1)#131

Merged
HumanBean17 merged 1 commit into
masterfrom
feat/filter-frame-vocabulary
May 14, 2026
Merged

feat: filter frame vocabulary renames (PR-FRAME-1)#131
HumanBean17 merged 1 commit into
masterfrom
feat/filter-frame-vocabulary

Conversation

@HumanBean17
Copy link
Copy Markdown
Owner

Scope

Implements PR-FRAME-1 from plans/PLAN-MCP-FILTER-FRAME.md (vocabulary audit / Appendix A in propose/MCP-FILTER-FRAME-PROPOSE.md).

  • Remove NodeFilter.client_method; the existing http_method field applies to both route and client kinds (16 NodeFilter fields).
  • Update _NODEFILTER_APPLICABLE_FIELDS, _node_matches_filter (client branch), and find_v2 client list_clients(method=...) wiring.
  • Update docs/AGENT-GUIDE.md: field table, http_method cross-kind note, source_layer vs role, target_service vs microservice.
  • Tests in tests/test_mcp_v2.py for cross-kind http_method behavior and rejection of the old field name.

Out of scope (per plan)

PR-FRAME-2/3 items (wildcards, describe(fqn=…), tool-description refresh, fail-loud counters, kuzu_queries.py rename of internal method=, ontology bump).

Manual evidence

.venv/bin/ruff check .
.venv/bin/python -m pytest tests -q

Result: 414 passed, 10 skipped (full tests/ run).

Sentinel: client_method absent from mcp_v2.py, server.py, docs/AGENT-GUIDE.md.

Test count

Five tests in scope for this PR: test_http_method_field_applies_to_route_kind, test_http_method_field_applies_to_client_kind, test_http_method_field_inapplicable_to_symbol, test_nodefilter_rejects_old_client_method_field, plus existing test_nodefilter_applicability_table_covers_all_fields.

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@HumanBean17 HumanBean17 merged commit c36b60f into master May 14, 2026
1 check passed
@HumanBean17 HumanBean17 deleted the feat/filter-frame-vocabulary branch May 23, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant