Skip to content

add plan and cursor prompts for hints v2#148

Merged
HumanBean17 merged 2 commits into
masterfrom
plan/hints-v2
May 16, 2026
Merged

add plan and cursor prompts for hints v2#148
HumanBean17 merged 2 commits into
masterfrom
plan/hints-v2

Conversation

@HumanBean17
Copy link
Copy Markdown
Owner

Summary

Test plan

  • Docs-only change (plan + prompts); no code or test execution required.
  • Reviewer: confirm PR breakdown, named tests, and out-of-scope match the propose.

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@HumanBean17
Copy link
Copy Markdown
Owner Author

Review (docs-only — approve in spirit)

Handoff for hints v2 looks good to merge as the execution blueprint. Aligns with merged propose (#146) and mirrors the landed v1 hints plan (#142). CI green; no code to exercise.


Strengths

  • Faithful to propose/HINTS-V2-PROPOSE.md: locked templates, FUZZY_STRATEGY_SET members, resolved_identifier echo, wildcard/120-char suppression, meta-tier priority, enforce strategy-classification invariant between brownfield pipeline and mcp_hints.py #147 deferred.
  • Solid agent contract: verbatim test_* names, substring assertions, sentinel greps, explicit PR-A → PR-B landing order.
  • Grounded in current code (ResolveOutput lacks hints; generate_hints has no resolve branch; neighbors already surfaces e.strategy in edge.attrs).

Suggestions before PR-HINTS-V2-A implementation

  1. Wildcard path — Today resolve_v2 early-returns wildcards via _resolve_build_output([]) without a unified success assembler. PR-A should call out refactoring so resolved_identifier=trimmed is set on every success=True path and hints stay [] via suppression (UC2c), not a separate shortcut.

  2. hint_kind + seed plumbing — Add an explicit PR-A step: thread trimmed, hint_kind, and parser-derived seeds into the hint payload on every success path (wildcard / empty-match included). hint_kind is only used for search routing today.

  3. Round-trip tests — Point implementers at existing tests/test_mcp_hints.py graph-discovery helpers (fail-loud, no unconditional skip) for test_hints_resolve_v2_round_trip and the neighbors fuzzy round-trip.

  4. PR-B test name — Plan lists test_hints_neighbors_empty_with_edge_types_still_emits_kind_check; existing test is ..._emits_kind_check. Align names to avoid an accidental duplicate.

  5. Propose hygienepropose/HINTS-V2-PROPOSE.md is still Status: draft on master after propose: hints-v2 — extend hints to resolve and to fuzzy-strategy neighbors signals #146. Update to approved or move to propose/completed/ when PR-B lands.


Nits

Happy to land a tiny plan amend for items 1–3 on this branch if useful.

Co-authored-by: Cursor <cursoragent@cursor.com>
@HumanBean17 HumanBean17 merged commit 9e78c9b into master May 16, 2026
1 check passed
HumanBean17 added a commit that referenced this pull request May 16, 2026
Hints v2 shipped in #148/#149/#150. Per repo convention, propose and
plans move to completed/ after the code lands.
@HumanBean17 HumanBean17 deleted the plan/hints-v2 branch May 23, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant