Skip to content

plan: schema-v2 and hints-v3 execution plans#155

Merged
HumanBean17 merged 3 commits into
masterfrom
plan/schema-v2-hints-v3
May 16, 2026
Merged

plan: schema-v2 and hints-v3 execution plans#155
HumanBean17 merged 3 commits into
masterfrom
plan/schema-v2-hints-v3

Conversation

@HumanBean17
Copy link
Copy Markdown
Owner

Summary

Test plan

  • Docs-only change; CI should skip pytest per paths-filter.
  • Review PR breakdown tables, per-PR test names, and sentinel grep contracts before merging.
  • After merge: SCHEMA-V2 PR-A implementation may start (HINTS-V3 propose already on master).

Made with Cursor

Execution-ready PR breakdown per PROPOSES-ORDER: EDGE_SCHEMA v14,
HTTP/ASYNC caller-side flips, Producer node, and PR-D hints v3 handoffs.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Copy Markdown
Owner Author

@HumanBean17 HumanBean17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Verdict: approve with small doc fixes (before or immediately after merge).

This is the right artefact at the right time — satisfies Decision 29 / docs/PROPOSES-ORDER.md Phase 2 so SCHEMA-V2 PR-A can start. Structure matches completed PLAN-* / CURSOR-PROMPTS-* pairs; sequencing (A→B→C→D), sentinel greps, and verbatim test names are strong.


Recommended fixes on this PR (or tiny follow-up)

  1. typical_traversals shape conflictpropose/SCHEMA-V2-PROPOSE.md Appendix A uses tuple[str, ...]; propose/HINTS-V3-PROPOSE.md §3.5 and these plans use dict[str, str] (role keys). PR-A should lock one line in PLAN-SCHEMA-V2.md + CURSOR-PROMPTS-SCHEMA-V2.md, e.g. PR-A contract: role-keyed dict[str, str] per HINTS-V3 §3.5; SCHEMA Appendix A tuple examples are illustrative only.

  2. member_only vs DECLARES_PRODUCER — HINTS §3.4 sets member_only on DECLARES_PRODUCER, but PR-A only ships 10 edges. Clarify PR-A sets flags on DECLARES_CLIENT, EXPOSES, OVERRIDES, CALLS only; PR-C adds DECLARES_PRODUCER when the edge lands.

  3. docs/PROPOSES-ORDER.md — Phase 2 still says plans “[not started]”; update after merge so the sequencing doc stays authoritative.

  4. propose/HINTS-V3-PROPOSE.md — still Status: draft on master though #154 merged; small chore PR before PR-D lock gate.


Non-blocking (first code PR is fine)

  • Add @tests/test_mcp_v2_compose.py to PR-B attach list (plan mentions it; prompt does not).
  • PR-C file-by-file should list pr_analysis.py (implementation step table already does) for async two-hop after PR-B’s HTTP leg.
  • Stale impact_analysis line anchor (~1335 vs ~1133 today).
  • Consider making test_hints_neighbors_v2_empty_post_flip_method_http_calls required once post-flip fixtures exist.

Pre-implementation notes (code PRs)

  • PR-A is not docs-only (workflow + generator) — full pytest will run; expected.
  • v14 + pre-flip endpoints until B/C complete — README callout is critical.
  • Freeze BROWNFIELD_RESOLVER_STRATEGY_SET members in PR-A body (same discipline as HTTP_CALLS grep).

Merge when the typical_traversals / member_only clarifications are in (here or immediate follow-up). Then SCHEMA PR-A can branch off master.

HumanBean17 and others added 2 commits May 16, 2026 17:46
Clarify role-keyed typical_traversals vs SCHEMA appendix tuples, split
member_only across PR-A/PR-C, update PROPOSES-ORDER phase 2, and align
prompts with pr_analysis and compose test coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>
Align propose, plan, and PROPOSES-ORDER headers with locked design and
active code rollout (PR-A–D); HINTS-V3 code remains SCHEMA-V2 PR-D.

Co-authored-by: Cursor <cursoragent@cursor.com>
@HumanBean17 HumanBean17 merged commit d2639b9 into master May 16, 2026
1 check passed
@HumanBean17 HumanBean17 deleted the plan/schema-v2-hints-v3 branch May 23, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant