fix(ontology): assign CLIENT role to message producer types#255
Merged
Conversation
Types injecting KafkaTemplate, RabbitTemplate, JmsTemplate, StreamBridge, or ApplicationEventPublisher now get CLIENT role (symmetry with CONTROLLER covering both HTTP and messaging inbound). Previously these fell through to OTHER despite having MESSAGE_PRODUCER capability. Ontology bumped 15 → 16; re-index required. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Remove navigate-codebase from EXPECTED_SKILL_DIRS (deleted in #254) - Rename test_has_worked_example → test_has_canonical_workflow to match actual section name after skill content was consolidated Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #253
KafkaTemplate,RabbitTemplate,JmsTemplate,StreamBridge,ApplicationEventPublisher) now getCLIENTrole instead of falling through toOTHERCONTROLLERcovers both HTTP and messaging inbound, butCLIENTonly covered HTTP outboundChanges
ast_java.py: Added_type_injects_messaging()helper and extendedinfer_role_for_type()to returnCLIENTwhen no annotation-based role was found but the type injects a messaging template. Annotation-based roles still win (e.g.@Serviceclass withKafkaTemplatestaysSERVICE).ast_java.pytest_resttemplate_class_gets_client_role_from_messagingreflects the new correct behaviorTest plan
test_client_role_rename.py: 9/9)CLIENTrole🤖 Generated with Claude Code