Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 87.61% 87.93% +0.32%
==========================================
Files 29 29
Lines 969 970 +1
==========================================
+ Hits 849 853 +4
+ Misses 120 117 -3
Continue to review full report at Codecov.
|
ttung
requested changes
Apr 2, 2018
|
|
||
|
|
||
| class _ClientMethodFactory(object): | ||
| retry_policy = RetryPolicy(read=10, status=10, status_forcelist=frozenset({502, 503, 504})) |
Member
There was a problem hiding this comment.
Do you want to add 500? c.f., HumanCellAtlas/dcp-preview#10
|
|
||
| class _ClientMethodFactory(object): | ||
| retry_policy = RetryPolicy(read=10, status=10, status_forcelist=frozenset({502, 503, 504})) | ||
| timeout_policy = timeout.Timeout(connect=300, read=300) |
Member
There was a problem hiding this comment.
Those both seem really high to me.
kislyuk
changed the base branch from
akislyuk-retry-streaming-read-errors
to
master
Tweak values
kislyuk
force-pushed
the
akislyuk-retry-streaming-read-errors-and-timeout
branch
from
e144fe3 to
e282d7d
Compare
Member
Author
|
Merging because https://travis-ci.org/HumanCellAtlas/dcp-cli/builds/361328725 (the pre-rebase version) succeeded & verbal approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.