Skip to content

Supplying the required version to dss.upload#135

Merged
Bento007 merged 2 commits intomasterfrom
tsmith-require-version
Jul 5, 2018
Merged

Supplying the required version to dss.upload#135
Bento007 merged 2 commits intomasterfrom
tsmith-require-version

Conversation

@Bento007
Copy link
Copy Markdown
Collaborator

@Bento007 Bento007 commented Jul 4, 2018

No description provided.

@Bento007
Copy link
Copy Markdown
Collaborator Author

Bento007 commented Jul 4, 2018

Here is the fix for the DSS HumanCellAtlas/data-store#1390

@Bento007 Bento007 force-pushed the tsmith-require-version branch from 88ac037 to 95fcaab Compare July 4, 2018 04:22
@Bento007 Bento007 force-pushed the tsmith-require-version branch from 95fcaab to 9f9de51 Compare July 4, 2018 04:38
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 4, 2018

Codecov Report

Merging #135 into master will increase coverage by 0.03%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   61.34%   61.37%   +0.03%     
==========================================
  Files          31       31              
  Lines        1177     1178       +1     
==========================================
+ Hits          722      723       +1     
  Misses        455      455
Impacted Files Coverage Δ
hca/dss/__init__.py 83.64% <62.5%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c80565...a828de8. Read the comment docs.

Copy link
Copy Markdown
Contributor

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to add this convenience to put-bundle? If so could you create a ticket for that here?

@Bento007
Copy link
Copy Markdown
Collaborator Author

Bento007 commented Jul 5, 2018

@hannes it's not worth the effort when upload does the same thing and is convenient enough.

@Bento007 Bento007 force-pushed the tsmith-require-version branch 3 times, most recently from a0aad1e to 3ab5129 Compare July 5, 2018 19:43
@Bento007 Bento007 force-pushed the tsmith-require-version branch from 3ab5129 to a828de8 Compare July 5, 2018 20:09
@Bento007 Bento007 merged commit 6ac14e6 into master Jul 5, 2018
@Bento007 Bento007 deleted the tsmith-require-version branch July 5, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants