Use s3 multipart constants as defined in dcplib#150
Merged
Conversation
mweiden
force-pushed
the
mweiden-issue149-dcplib-constants
branch
from
ebea208 to
3172483
Compare
mweiden
commented
Aug 1, 2018
| return "application/octet-stream" | ||
|
|
||
|
|
||
| def _copy_from_s3(path, s3, tx_cfg): |
Contributor
Author
There was a problem hiding this comment.
tx_cfg isn't used anywhere?
mweiden
force-pushed
the
mweiden-issue149-dcplib-constants
branch
from
3172483 to
e2a95b8
Compare
mweiden
force-pushed
the
mweiden-issue149-dcplib-constants
branch
from
e2a95b8 to
2efb8ca
Compare
Contributor
Author
|
@ttung @sampierson will take this out of WIP when #150 is merged and |
ttung
approved these changes
Aug 1, 2018
|
|
||
|
|
||
| def _copy_from_s3(path, s3, tx_cfg): | ||
| def _copy_from_s3(path, s3): |
Member
There was a problem hiding this comment.
kind of confused why this method has this name, but probably out of the scope of this diff.
mweiden
force-pushed
the
mweiden-issue149-dcplib-constants
branch
from
2efb8ca to
84f3a0e
Compare
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 86.43% 88.27% +1.83%
==========================================
Files 32 32
Lines 1202 1279 +77
==========================================
+ Hits 1039 1129 +90
+ Misses 163 150 -13
Continue to review full report at Codecov.
|
mweiden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
Blocked by HumanCellAtlas/dcplib#2