Support for OIDC JWT for Authentication#178
Merged
Conversation
Bento007
force-pushed
the
tsmith-oidc-jwt-compat
branch
from
0195736 to
705009e
Compare
kislyuk
approved these changes
Sep 2, 2018
Bento007
force-pushed
the
tsmith-oidc-jwt-compat
branch
2 times, most recently
from
2796bab to
788838a
Compare
* added _get_jwt_from_service_account_credentials * added manual login tests.
Bento007
force-pushed
the
tsmith-oidc-jwt-compat
branch
from
788838a to
536865b
Compare
kislyuk
reviewed
Sep 7, 2018
|
|
||
| audience = "https://dev.data.humancellatlas.org/" | ||
| iat = time.time() | ||
| exp = iat + 3600 |
Member
There was a problem hiding this comment.
Probably good to parameterize this through a kwarg to this method.
Collaborator
Author
There was a problem hiding this comment.
will fix once we figure out how to store and reuse the token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JWT are now generated and used for authentication with the dss as outlined in https://allspark.dev.data.humancellatlas.org/dcp-ops/docs/wikis/Security/Authentication%20and%20Authorization/Setting%20up%20DCP%20Auth
This and HumanCellAtlas/data-store#1542 are dependent on each other for integration tests to pass. This needs to be merge this after HumanCellAtlas/data-store#1542.