Conversation
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=========================================
+ Coverage 83.39% 83.4% +0.01%
=========================================
Files 37 37
Lines 1554 1555 +1
=========================================
+ Hits 1296 1297 +1
Misses 258 258
Continue to review full report at Codecov.
|
kislyuk
left a comment
There was a problem hiding this comment.
I think the way to fix this is not by introducing new import-time side effects, but to make sure instantiation of the client happens in docs/conf.py. I think the regression happened in the following diff, and just reverting its effect should fix this:
https://github.com/HumanCellAtlas/dcp-cli/pull/146/files#diff-85987f48f1258d9ee486e3191495582dL25
You might consider inserting a comment to not accidentally remove these imports again.
|
(Also, in re: #146, whenever changing the doc build process, a good practice is to diff the output of the old build vs. the new.) |
Instantiating DSS_Client in the doc/config.py ensures DSS swagger.yml APIs is parsed and included in the class before the sphinx parser runs.
62a3d66 to
971ac98
Compare
Instantiate DSSClient to generate the documentation for swagger API binding