reduce threads running on upload and reraise error from tenacity on upload methods#228
Merged
parthshahva merged 1 commit intomasterfrom Feb 12, 2019
Merged
Conversation
parthshahva
changed the title
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 83.39% 83.91% +0.51%
==========================================
Files 37 37
Lines 1554 1554
==========================================
+ Hits 1296 1304 +8
+ Misses 258 250 -8
Continue to review full report at Codecov.
|
sampierson
approved these changes
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users have reported issues with too many threads running. This fix reduces the number of threads running as a relationship with cpu count. This PR also adds reraise=True to all retries to ensure all errors are logged appropriately.