Skip to content

Support optional object parameters#229

Merged
xbrianh merged 3 commits intomasterfrom
bhannafi-optional-objects
Feb 14, 2019
Merged

Support optional object parameters#229
xbrianh merged 3 commits intomasterfrom
bhannafi-optional-objects

Conversation

@xbrianh
Copy link
Copy Markdown
Member

@xbrianh xbrianh commented Feb 14, 2019

No description provided.

@xbrianh xbrianh requested review from Bento007 and kislyuk February 14, 2019 11:23
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0d451f0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #229   +/-   ##
=========================================
  Coverage          ?   83.91%           
=========================================
  Files             ?       37           
  Lines             ?     1554           
  Branches          ?        0           
=========================================
  Hits              ?     1304           
  Misses            ?      250           
  Partials          ?        0
Impacted Files Coverage Δ
hca/util/__init__.py 89.06% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d451f0...50a447e. Read the comment docs.

Copy link
Copy Markdown
Member

@kislyuk kislyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we have a test please?

Brian Hannafious added 2 commits February 14, 2019 09:50
@xbrianh xbrianh merged commit 83a64a6 into master Feb 14, 2019
@xbrianh xbrianh deleted the bhannafi-optional-objects branch February 14, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants