Adding GOOGLE_APPLICATION_CREDENTIALS to readme.#242
Merged
Conversation
kislyuk
requested changes
Feb 22, 2019
Member
kislyuk
left a comment
kislyuk
left a comment
There was a problem hiding this comment.
-
This applies only to SwaggerClient based clients, right?
-
This is a service-to-service auth mechanism, and we should add here that the services authorized to access the API this way will have to be whitelisted. I think this should be noted as "for HCA/DCP developers".
-
Please include a link to the service account docs (https://cloud.google.com/iam/docs/understanding-service-accounts) and console page for creating service accounts (https://console.cloud.google.com/iam-admin/serviceaccounts).
- included link about google service credentials - targeting HCA/DCP developers
kislyuk
reviewed
Feb 22, 2019
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| For HCA/DCP developers using the HCA-CLI to connect their service, | ||
| google service credentials can be used to authenticate the service's API requests. The google service credentials must be |
Member
There was a problem hiding this comment.
"The google service account must be whitelisted"
Capitalize Google
"HCA-CLI" -> "HCA CLI"
kislyuk
approved these changes
Feb 22, 2019
xbrianh
approved these changes
Feb 23, 2019
| For HCA/DCP developers using the HCA-CLI to connect their service, | ||
| google service credentials can be used to authenticate the service's API requests. The google service credentials must be | ||
| whitelisted before they will authenticate with the HCA-CLI. The environment variable `GOOGLE_APPLICATION_CREDENTIALS` | ||
| should be set to the path of google service credentials file. This allows the HCA-CLI to be |
Member
There was a problem hiding this comment.
"the google service credentials file"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.