Slash-Support : supporting '/' within upload/download for files in bundles#266
Slash-Support : supporting '/' within upload/download for files in bundles#266
Conversation
…path is the default.
…to slash-support
mikebaumann
left a comment
mikebaumann
left a comment
There was a problem hiding this comment.
Amar, please add a unit test that actually uses the command line interface (not just the Python bindings), to both verify this fix and prevent similar similar errors occurring in the future. Thanks!
mikebaumann
left a comment
mikebaumann
left a comment
There was a problem hiding this comment.
Hi @amarjandu, please address the comments I added .... thanks!
| parser = get_parser() | ||
|
|
||
| if len(sys.argv) < 2: | ||
| if len(args) < 2: |
There was a problem hiding this comment.
This test used to be performed using sys.argv, which includes the script name as sys.argv[0], but args does not include the script name, so this:
if len(args) < 2
should be changed to:
if len(args) < 1
There was a problem hiding this comment.
i added this change but needed to also perform
if not args:
args = sys.argv[1:]
this resolves a parsing issue with the script name
|
@amarjandu Assuming you are going to squash and merge this, please:
|
mikebaumann
left a comment
mikebaumann
left a comment
There was a problem hiding this comment.
Added another comment, still reviewing ...
amarjandu
changed the title
| def main(args=None): | ||
| if '--help' in sys.argv or '-h' in sys.argv: | ||
| if not args: | ||
| args = sys.argv[1:] |
There was a problem hiding this comment.
@DailyDreaming i had to do this to get around parser issue when trying to use the cli after performing a make install everything works within testing + manual cli usage. Can you think of a reason it would break a parser later on?
There was a problem hiding this comment.
No, I think that was the correct call.
…ndles (#266) Supporting / within upload/download for files in bundles Address the need to support nested folders/files within bundle structures. Imaging data bundles will have specifc file structures that neeed to be preserved the same when being uploaded or downloaded to the DSS. This also addresses a workaround for the matrix team where ! was being used due to not having slash-support Resolves: #261 See also: HumanCellAtlas/data-store#1885
5 participants
Supporting
/within upload/download for files in bundlesAddress the need to support nested folders/files within bundle
structures.
Imaging data bundles will have specifc file structures that neeed to
be preserved the same when being uploaded or downloaded to the DSS.
This also addresses a workaround for the matrix team where
!wasbeing used due to not having slash-support
Resolves: #261
See also: HumanCellAtlas/data-store#1885