Skip to content

Updating boto3 version#282

Merged
maniarathi merged 2 commits intomasterfrom
b273
Mar 21, 2019
Merged

Updating boto3 version#282
maniarathi merged 2 commits intomasterfrom
b273

Conversation

@maniarathi
Copy link
Copy Markdown
Contributor

Previous 1.7-1.8 requirement is incompatible with upload service. Also alphabetized the dependencies.

@xbrianh
Copy link
Copy Markdown
Member

xbrianh commented Mar 20, 2019

@parthshahva Is Upload prepared for this boto3 version bump?

@sampierson
Copy link
Copy Markdown
Member

sampierson commented Mar 20, 2019

@xbrianh yes Upload is the one initiating this (Arathi works on Upload)

@parthshahva
Copy link
Copy Markdown
Contributor

@maniarathi @sampierson The upgrade of boto3 breaks the use of mock in our tests, leading to a slate of permission denied errors on CreateBucket. We'll need to fix our tests before merging this in.

Copy link
Copy Markdown
Member

@xbrianh xbrianh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, merge with caution :)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 21, 2019

Codecov Report

Merging #282 into master will increase coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   83.17%   83.64%   +0.46%     
==========================================
  Files          37       37              
  Lines        1724     1724              
==========================================
+ Hits         1434     1442       +8     
+ Misses        290      282       -8
Impacted Files Coverage Δ
hca/version.py 100% <100%> (ø) ⬆️
hca/util/__init__.py 87.42% <0%> (+0.28%) ⬆️
hca/cli.py 66.95% <0%> (+6.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae711e...c7d2161. Read the comment docs.

@maniarathi maniarathi merged commit 7238f58 into master Mar 21, 2019
@maniarathi maniarathi deleted the b273 branch March 21, 2019 17:49
@kislyuk
Copy link
Copy Markdown
Member

kislyuk commented Oct 18, 2019

Only direct package dependencies (those imported by the library) should be listed here. Dependencies should manage their sub-dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants