Conversation
Collaborator
Bento007
commented
Aug 19, 2019
Bento007
commented
- Changed refresh_swagger to clear_cache
- Fixed type in clear_cache documentation
- Adding clear-hca-cache to CLI to clear the cache of all SwaggerClients subclasses.
- Updated tests and tutorials.
- Changed refresh_swagger to clear_cache - Fixed typo in clear_cache documentation - Adding clear-hca-cache to CLI to clear the cache of all SwaggerClients subclasses. - Updated tests and tutorials.
Bento007
force-pushed
the
tsmith-clear-cache
branch
from
03a1801 to
2b798b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
- Coverage 85.72% 85.61% -0.12%
==========================================
Files 39 39
Lines 1857 1863 +6
==========================================
+ Hits 1592 1595 +3
- Misses 265 268 +3
Continue to review full report at Codecov.
|
kislyuk
approved these changes
Aug 25, 2019
Member
kislyuk
left a comment
kislyuk
left a comment
There was a problem hiding this comment.
LGTM pending minor changes, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.