Skip to content

pin docutils in requirements.txt#511

Merged
amarjandu merged 2 commits intomasterfrom
amar-req-doc
Feb 11, 2020
Merged

pin docutils in requirements.txt#511
amarjandu merged 2 commits intomasterfrom
amar-req-doc

Conversation

@amarjandu
Copy link
Copy Markdown
Contributor

User states that an error occurs when installing the hca tool with conda

Due to conflicting docutils version pinned in requirements.txt and from within botocore, conda is unable to install the hca tool correctly.

Issue also observed when trying to perform a pip install -r requirements.txt within a clean virtual env.

requirements.txt Outdated
# The version range of docutils is pinned by botocore. Pinning it here can cause a version conflict.
# See https://github.com/boto/botocore/pull/1802, https://github.com/HumanCellAtlas/dcp-cli/issues/418
docutils
# docutils
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kislyuk I'm unsure if this should be handled by commenting out the pinned requirement or removing ln21 entirely; i would like to keep the comment above, but don't want the un-pinning/removal to go unnoticed by another developer. Any recommendation?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be docutils < 0.16 as per boto/botocore@a8bbf60

@amarjandu amarjandu self-assigned this Feb 10, 2020
@amarjandu amarjandu added the BUG label Feb 10, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 10, 2020

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files          40       40           
  Lines        1893     1893           
=======================================
  Hits         1621     1621           
  Misses        272      272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d585fd8...eb2260f. Read the comment docs.

@amarjandu
Copy link
Copy Markdown
Contributor Author

@chmreid im going to wait for EOD today (2-10-20) before merging this and pushing up a new patch, just in-case Andrey had a recommendation.

@amarjandu amarjandu changed the title Remove docutils from requirements pin docutils in requirements.txt Feb 11, 2020
@amarjandu amarjandu merged commit 556ec45 into master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants