Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 87.66% 87.54% -0.13%
==========================================
Files 28 28
Lines 924 931 +7
==========================================
+ Hits 810 815 +5
- Misses 114 116 +2
Continue to review full report at Codecov.
|
|
Let me plug https://github.com/HumanCellAtlas/data-store/blob/master/dss/util/retry.py#L14 here which could also be used for this if it weren't in a different project. |
time for |
kislyuk
left a comment
There was a problem hiding this comment.
urllib3 has retry logic built in. This retry policy logic can be customized and accessed via requests via the max_retries kwarg, to which you can pass a urllib3.Retry() object, which you can configure or subclass to customize this behavior.
Let's switch to using that functionality.
e8982d0 to
af08821
Compare
|
Updated to use urllib3 retry. |
1. Add a retry policy class that dictates which requests are retried and how often they are retried. 2. Add a test that uses the fake 504 mechanism in data-store to test the retry policy. Connects to HumanCellAtlas/data-store#485
Connects to HumanCellAtlas/data-store#485