Skip to content

Retry on read errors.#97

Merged
kislyuk merged 1 commit intomasterfrom
tonytung-retry
Mar 30, 2018
Merged

Retry on read errors.#97
kislyuk merged 1 commit intomasterfrom
tonytung-retry

Conversation

@ttung
Copy link
Copy Markdown
Member

@ttung ttung commented Mar 30, 2018

No description provided.

@ttung ttung requested a review from kislyuk March 30, 2018 16:47
@briandoconnor
Copy link
Copy Markdown

@ttung are there any other places in the code base that the retry policy needs to be tweaked or is this it?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 30, 2018

Codecov Report

Merging #97 into master will increase coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage      88%   88.33%   +0.33%     
==========================================
  Files          29       29              
  Lines         967      986      +19     
==========================================
+ Hits          851      871      +20     
+ Misses        116      115       -1
Impacted Files Coverage Δ
hca/util/__init__.py 91.56% <100%> (ø) ⬆️
hca/dss/__init__.py 94.05% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d6324...902e37e. Read the comment docs.

@kislyuk kislyuk merged commit f8bc8f5 into master Mar 30, 2018
@kislyuk kislyuk deleted the tonytung-retry branch March 30, 2018 17:07
@ttung
Copy link
Copy Markdown
Member Author

ttung commented Mar 30, 2018

@ttung are there any other places in the code base that the retry policy needs to be tweaked or is this it?

shouldn't be.

@ttung
Copy link
Copy Markdown
Member Author

ttung commented Mar 30, 2018

We may need to tweak the retry policy more as we see what kind of errors we encounter / how often we encounter them.

@kislyuk
Copy link
Copy Markdown
Member

kislyuk commented Mar 30, 2018

Released in v3.4.2, please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants