Skip to content

Add OpenAPI Headers for Pagination#291

Merged
amarjandu merged 12 commits intomasterfrom
amar-Propogate-Integral-Multipurpose-Pages
Nov 20, 2019
Merged

Add OpenAPI Headers for Pagination#291
amarjandu merged 12 commits intomasterfrom
amar-Propogate-Integral-Multipurpose-Pages

Conversation

@amarjandu
Copy link
Copy Markdown
Contributor

Adds 'X-OpenAPI-Pagination' , 'X-OpenAPI-Paginated-Content-Key' as headers for paged responses.

@amarjandu amarjandu requested a review from Bento007 October 19, 2019 06:54
@amarjandu amarjandu self-assigned this Oct 19, 2019
@amarjandu amarjandu changed the title Propogate Missing Pages [wip] Add OpenAPI Headers for Pagination Oct 19, 2019
@amarjandu
Copy link
Copy Markdown
Contributor Author

Cant run tests locally. make gets suck... 🤔

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 19, 2019

Codecov Report

Merging #291 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   88.58%   88.59%   +0.01%     
==========================================
  Files          24       24              
  Lines        1971     1973       +2     
==========================================
+ Hits         1746     1748       +2     
  Misses        225      225
Impacted Files Coverage Δ
fusillade/api/users/__init__.py 93.54% <100%> (+0.1%) ⬆️
fusillade/api/roles/__init__.py 100% <100%> (ø) ⬆️
fusillade/api/paging.py 96.87% <100%> (+0.1%) ⬆️
fusillade/api/groups/__init__.py 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8872a7e...7f4e9f5. Read the comment docs.

@amarjandu amarjandu changed the title [wip] Add OpenAPI Headers for Pagination Add OpenAPI Headers for Pagination Nov 19, 2019
Copy link
Copy Markdown
Collaborator

@Bento007 Bento007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes, is this documentation still needed:

# Pagination

Comment thread fusillade-api.yml Outdated
@amarjandu amarjandu requested a review from Bento007 November 19, 2019 18:06
Copy link
Copy Markdown
Collaborator

@Bento007 Bento007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarjandu amarjandu merged commit fb95c30 into master Nov 20, 2019
@amarjandu amarjandu deleted the amar-Propogate-Integral-Multipurpose-Pages branch November 20, 2019 20:08
Bento007 pushed a commit that referenced this pull request Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants