Merged
Conversation
Collaborator
Bento007
commented
Nov 1, 2019
Bento007
commented
- Fixing batch reference name. The name used was incorrect.
- Fixing batch_write retries. 'allowed_errors' didn't match due to an extra ':' at the end of the parsed error from the batch_write call.
- Correcting typing
- Cleaning up swagger spacing
- Removing unused code
- Fixing batch reference name. The name used was incorrect. - Fixing batch_write retries. 'allowed_errors' didn't match due to an extra ':' at the end of the parsed error from the batch_write call. - Correcting typing - Cleaning up swagger spacing - Removing unused code
amarjandu
approved these changes
Nov 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 89.81% 89.31% -0.51%
==========================================
Files 18 18
Lines 1660 1657 -3
==========================================
- Hits 1491 1480 -11
- Misses 169 177 +8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.