Copy to make arrays mutable for PyTorch #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 79 79
Lines 5802 5805 +3
=======================================
+ Hits 5215 5218 +3
Misses 587 587
Continue to review full report at Codecov.
|
Member
Author
|
@qxcv will you have time to review? If not I'll ask someone else to take a look. |
Member
|
Yep, can review! |
qxcv
approved these changes
Sep 6, 2021
Member
qxcv
left a comment
qxcv
left a comment
There was a problem hiding this comment.
Looks good to me. I'm not too worried about perf impact. It it's a bottleneck (e.g. for image envs with huge observations) then it should be pretty obvious from profiling later on, since it's just one function call.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219
May introduce a slight performance overhead -- I've not tested. @shwang thought PyTorch was soft-copying anyway. I expect this to be insignificant for current workloads, we can do something smarter if/when profiling reveals this is an issue.