Skip to content

Enable git lfs#683

Merged
ernestum merged 3 commits into
masterfrom
enable_git_lfs
Feb 24, 2023
Merged

Enable git lfs#683
ernestum merged 3 commits into
masterfrom
enable_git_lfs

Conversation

@ernestum
Copy link
Copy Markdown
Collaborator

@ernestum ernestum commented Feb 21, 2023

Description

For some testdata we rather want to store it using git LFS. We need this for the new tests in #677 but I decided to pull this out to ensure there is no scope-creep in #677.
I also updated the cuda version along the way.
This is modeled mostly after https://naiyer.dev/post/2020/09/05/using-git-lfs-in-ci/

Testing

I initially based this on top of huggingface_datasets branch because I needed it there. The pipeline there succeeded (with some LFS objects in the history).

Before Merging

We need to change the image from base-alpha to base!!!

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2023

Codecov Report

Merging #683 (e85b2a6) into master (785e31b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          89       89           
  Lines        8618     8618           
=======================================
  Hits         8300     8300           
  Misses        318      318           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- 1 small comment

Comment thread .circleci/config.yml
@ernestum ernestum merged commit 622092c into master Feb 24, 2023
@ernestum ernestum deleted the enable_git_lfs branch February 24, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants