This repository was archived by the owner on Apr 18, 2024. It is now read-only.
internal: DEV-4081: LSDV-2984: Magic Wand tool #1132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements a Magic Wand, making it possible to click in a region of an image a user is doing segmentation labeling on, drag the mouse to dynamically change flood filling tolerance, then release the mouse button to get a new labeled area. It is particularly effective at labeling broad, diffuse, complex edged objects, such as clouds, cloud shadows, snow, etc. in earth observation applications or organic shapes in biomedical applications. In-depth technical overview on how it works at the top of src/tools/MagicWand.js.
|
✅ Linked to Task DEV-4081 · Review and merge Implements Magic Wand tool PR |
Codecov ReportBase: 9.45% // Head: 9.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
=========================================
- Coverage 9.45% 9.14% -0.31%
=========================================
Files 108 107 -1
Lines 7830 8111 +281
Branches 1963 2014 +51
=========================================
+ Hits 740 742 +2
- Misses 5947 6187 +240
- Partials 1143 1182 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 13 commits
January 5, 2023 09:39
The old bucket was configured under the wrong project, and using https instead of http causes mixed content issues for CORS. Local development is done with http so using that.
This means undo/redo will now work correctly, but will end up creating a new class layer if more magic wanding is done on the current instance.
…nt deployment scenarios.
…will have it off by default. Note that this is needed so that Magic Wand e2e integration tests will work.
added 10 commits
January 26, 2023 09:19
…getting duplicated.
To do this, we have to ensure that the eraser doesn't get added twice if the brush tag is also present.
hlomzik
changed the title
Note that we have not been able to make sure the docs are generated correctly until the https://api.github.com/repos/heartexlabs/label-studio/contents/docs/source/tags API endpoint registers the magicwand tag.
Basically, we now calculate the Magic Wand thresholding from the entire screen, not just relative to the image. We also correctly allow you to drag in any direction to get positive or negative thresholding.
…me tools. The Magic Wand, the Brush, and the Eraser should all retain selection when moving between them, as well as when moving between those tools and the Zoom or Pan tools. This fix allows removing some hacky specific code I added for the Magic Wand for this behavior. Fixes HumanSignal/label-studio#3510.
Collaborator
Author
|
Original PR is merged, all related are merged as well, so closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal PR to include #1119 in our process.
#1119 should be merged first, all comments should go there. All credits to the author of original PR and all participants.
This PR should be automatically updated and merged after original PR is merged.