-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: OPTIC-2017: Select follow ups #7415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Co-authored-by: bmartel <brandonmartel@gmail.com>
Co-authored-by: bmartel <brandonmartel@gmail.com>
Co-authored-by: bmartel <brandonmartel@gmail.com>
|
/fm sync |
|
@yyassi-heartex Shouldn't |
yeah this is needed in LSE ModelVersionSelector - there is a very specific use case where it relies on the first option being selected if no value is provided |
|
@yyassi-heartex I was going to ask the same question as @nass600, because we really don't want to bake in a functionality that is necessitated by a bad upstream implementation, if anything we would handle that at the location site of the Select and not force Select to have domain specific implementation details. |
|
/git merge
|
|
/fm sync |
|
/fm sync |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7415 +/- ##
========================================
Coverage 78.40% 78.40%
========================================
Files 193 193
Lines 15624 15624
========================================
Hits 12250 12250
Misses 3374 3374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request introduces several updates across the
CreateProjectpage and theSelectcomponent, focusing on improving functionality, user experience, and code maintainability. The most significant changes include adding a newselectFirstIfEmptyprop to theSelectcomponent, updating styles and behavior for theCreateProjectpage, and renaming a prop for clarity.Updates to the
Selectcomponent:selectFirstIfEmptyprop to automatically select the first option if no initial value is provided. This includes updates to the logic for determining the initial value and handling state changes (web/libs/ui/src/lib/select/select.tsx). [1] [2] [3]isInProgressprop toisLoadingfor better clarity and consistency (web/libs/ui/src/lib/select/types.ts).Optioncomponent to simplify styles (web/libs/ui/src/lib/select/select.tsx).Updates to the
CreateProjectpage:Captionelement to display as a block for better layout control (web/apps/labelstudio/src/pages/CreateProject/CreateProject.scss).Captionelement to ensure proper spacing in the rendered output (web/apps/labelstudio/src/pages/CreateProject/CreateProject.jsx).