Skip to content

Make Storage export formats identical to regular JSON export#762

Merged
niklub merged 5 commits intomasterfrom
fix/s3-export-task-format
May 18, 2021
Merged

Make Storage export formats identical to regular JSON export#762
niklub merged 5 commits intomasterfrom
fix/s3-export-task-format

Conversation

@niklub
Copy link
Copy Markdown
Collaborator

@niklub niklub commented Apr 6, 2021

That fixes HumanSignal/label-studio-converter#28 (comment)

To use LS Task JSON format in target storages, you should set this environment variable:

FUTURE_SAVE_TASK_TO_STORAGE=1

and then run Label Studio.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2021

Unit Test Results

    1 files  ±0      1 suites  ±0   4m 12s ⏱️ -15s
339 tests ±0  263 ✔️ ±0  76 💤 ±0  0 ❌ ±0 

Results for commit bd82ac5. ± Comparison against base commit b4c1090.

smoreface added a commit that referenced this pull request Apr 16, 2021
* Fixing incorrect syntax on -db vs --db
* Adding target storage mention to local files to account for #762 changes
@niklub niklub added this to the Label Studio 1.0.2 milestone Apr 20, 2021
smoreface added a commit that referenced this pull request Apr 27, 2021
* Adding local storage with docker info

* Local file storage updates

Docker, env variables, example task reference, and cross links

* Updating docker info

Addressing review comments, especially rewriting example of volume mounts and adding a bind mount example to be clearer.

* Fixing syntax

* Fixing incorrect syntax on -db vs --db
* Adding target storage mention to local files to account for #762 changes

* Env var updates

Adding a new link ref
Updating environment variable info to be a true prereq
Added smol info about env vars

* Updating for review feedback

* Updating docker commands
* Clarifying env vars
* Removing duplicate info
@niklub niklub marked this pull request as ready for review May 18, 2021 14:36
@codecov
Copy link
Copy Markdown

codecov bot commented May 18, 2021

Codecov Report

Merging #762 (6a23325) into master (a954e73) will increase coverage by 0.02%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
+ Coverage   69.56%   69.58%   +0.02%     
==========================================
  Files         115      115              
  Lines        7776     7779       +3     
==========================================
+ Hits         5409     5413       +4     
+ Misses       2367     2366       -1     
Impacted Files Coverage Δ
label_studio/io_storages/localfiles/models.py 47.36% <0.00%> (ø)
label_studio/io_storages/redis/models.py 72.05% <0.00%> (ø)
label_studio/io_storages/base_models.py 80.27% <77.77%> (-0.17%) ⬇️
label_studio/core/label_config.py 77.38% <100.00%> (+0.45%) ⬆️
label_studio/data_export/serializers.py 100.00% <100.00%> (+10.00%) ⬆️
label_studio/io_storages/azure_blob/models.py 84.07% <100.00%> (ø)
label_studio/io_storages/gcs/models.py 85.24% <100.00%> (ø)
label_studio/io_storages/s3/models.py 84.67% <100.00%> (-0.37%) ⬇️
label_studio/tasks/serializers.py 77.27% <100.00%> (-0.22%) ⬇️
label_studio/tasks/validation.py 53.96% <100.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a954e73...6a23325. Read the comment docs.

@niklub niklub merged commit 8cfdc0e into master May 18, 2021
@nick-skriabin nick-skriabin deleted the fix/s3-export-task-format branch August 12, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON to CSV converter ignores multiple annotations of each task (LS 1.0)

2 participants