Skip to content

Comments

fix: FIT-932: Remove Unnecessary margin on right side of DM#9162

Merged
robot-ci-heartex merged 6 commits intodevelopfrom
fb-fit-932
Jan 14, 2026
Merged

fix: FIT-932: Remove Unnecessary margin on right side of DM#9162
robot-ci-heartex merged 6 commits intodevelopfrom
fb-fit-932

Conversation

@ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Jan 12, 2026

This pull request makes several UI improvements to the table component, focusing on the appearance and alignment of the "show-source" column and enhancing the styling for even table rows. The changes refine both the component's JSX structure and its associated SCSS styles.

Screenshots

Before

Cursor_and_Community_-_Label_Studio

After

Cursor_and_LSO_Local

Table column adjustments:

  • Increased the width of the "show-source" column from 40px to 44px in both the column style and header, and added a headerClassName for more precise styling (Table.jsx).

Styling improvements:

  • Fixed a class naming typo from table__row_wrapper_selected to table__row-wrapper_selected and added a decorative ::after pseudo-element to even table rows for improved visual separation (Table.scss).
  • Updated the .table__cell class to add a .show-source modifier, removing padding for cells in the "show-source" column to improve alignment (Table.scss).

@ricardoantoniocm ricardoantoniocm self-assigned this Jan 12, 2026
@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8772ccb
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/6966d40263e4430008705ece

@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8772ccb
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/6966d4022ceea8000877bb0b

@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 8772ccb
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/6966d40263e4430008705ed2

@github-actions github-actions bot added the fix label Jan 12, 2026
@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit 8772ccb
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/6966d4027f50a20008836566

@ricardoantoniocm ricardoantoniocm changed the title fix: FIT-932: Unnecessary margin on right side of DM and Quick View t… … fix: FIT-932: Remove Unnecessary margin on right side of DM Jan 12, 2026
@ricardoantoniocm ricardoantoniocm requested a review from a team January 12, 2026 20:11
@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review January 12, 2026 20:12
@ricardoantoniocm ricardoantoniocm requested a review from a team as a code owner January 12, 2026 20:12
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.95%. Comparing base (aafa25d) to head (8772ccb).
⚠️ Report is 8 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (aafa25d) and HEAD (8772ccb). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aafa25d) HEAD (8772ccb)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9162      +/-   ##
===========================================
- Coverage    66.74%   57.95%   -8.80%     
===========================================
  Files          828      557     -271     
  Lines        64801    40433   -24368     
  Branches     10939    10939              
===========================================
- Hits         43253    23432   -19821     
+ Misses       21544    16997    -4547     
  Partials         4        4              
Flag Coverage Δ
lsf-e2e 52.41% <ø> (+0.43%) ⬆️
lsf-integration 48.24% <ø> (ø)
lsf-unit 8.86% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Jan 13, 2026

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/src/types/truncate-middle.d.ts

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Jan 13, 2026

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/layers2.svg

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Jan 13, 2026

/git merge

Workflow run
Successfully merged: 1 file changed, 14 insertions(+), 28 deletions(-)

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! this margin on the right has been bugging me for a long time!

@robot-ci-heartex robot-ci-heartex merged commit 58668a0 into develop Jan 14, 2026
46 of 47 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-932 branch January 14, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants