Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kotlin + Spring 서버 코드의 공통 스타일 기준을 문서/도구로 고정하고,
설정 하드코딩 제거 및 핵심 서비스 가독성 리팩토링을 적용했습니다.
이번 PR은 아래 4가지를 목표로 합니다.
docs+ lint/format)상위 의도 / 하위 구현)변경 사항
docs
(
docs/code-style-guide.md,docs/code-style-guide.ko.md)(
docs/readability-refactoring-case-study.ko.md)(
docs/pr-draft-style-readability-v1.ko.md)chore (format/lint baseline)
.editorconfig추가ktlint최신 호환 설정 반영 (build.gradle.kts및 모듈 build 파일)fix
application.yml/property로 외부화AnomalyDetector스케줄 표현식 정리SimulatorController/TrafficSimulator입력 검증 강화refactor
sendNotificationsInBatches)style
@see표기 통일chore (frontend)
.nvmrc추가package.jsonengines 갱신console.log제거NOT bugs (검증 완료, 오탐/비대상)
./gradlew ktlintCheck test일괄 실행 실패는 이번 변경 이슈가 아니라common-avro태스크 implicit dependency 검증 문제(기존 Gradle 구성 이슈)로 확인Test Plan
./gradlew ktlintFormat -q./gradlew ktlintCheck -q./gradlew test -q./gradlew :notification-service:compileKotlin :simulator:compileKotlin -qnpm run build(Node 20.19+/22 환경에서 확인 필요)/tracing포함)커밋 내역
de5dd73docs: Kotlin+Spring 코드 스타일 가이드 v1 및 학습 문서 추가f0f330dchore: 루트 포맷/린트 기준 정비 및 ktlint 설정 반영70fc86efix: 설정 하드코딩 제거 및 시뮬레이터 입력 검증 강화cc7f894refactor: EventDetector/LoadTestService 가독성 중심 구조 개선3a09e53chore(frontend): Node 버전 명시 및 ESLint 규칙 정리b1640cbstyle: Kotlin import/KDoc/Qualifier/로거 스타일 일관화