Skip to content

New spells Spiritus and Expelliarmus#12

Merged
HyScript7 merged 14 commits intoHyScript7:feat/content_update_1from
youngcoder45:yc45-pr
Dec 8, 2025
Merged

New spells Spiritus and Expelliarmus#12
HyScript7 merged 14 commits intoHyScript7:feat/content_update_1from
youngcoder45:yc45-pr

Conversation

@youngcoder45
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 5, 2025 07:46

This comment was marked as outdated.

@HyScript7
Copy link
Owner

HyScript7 commented Dec 7, 2025

Can you change the target branch to the content update one? Thanks.
also why is copilot reviewing this PR 💔

@HyScript7 HyScript7 changed the base branch from Main to feat/content_update_1 December 7, 2025 20:50
@HyScript7
Copy link
Owner

turns out I can do it myself

@youngcoder45
Copy link
Contributor Author

turns out I can do it mysel

Dw I am adding 2 more things rn so wait

@youngcoder45
Copy link
Contributor Author

Can you change the target branch to the content update one? Thanks.
also why is copilot reviewing this PR 💔

Lmao

Copy link
Owner

@HyScript7 HyScript7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct

@youngcoder45
Copy link
Contributor Author

Alright I am done read docs if u need more help, rest has already been reviewed by copilot also i checked twice on localhost all works, u can read docs if everything is good, then u can merge right now ( merge little soon btw )

@EventHandler(priority = EventPriority.LOWEST)
public void onDebugChat(AsyncChatEvent event) {
String message = PlainTextComponentSerializer.plainText().serialize(event.message());

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an operator check. Then we can merge.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also since you wrote this in my package, either move it or add a copyright comment at the start of the file.

@youngcoder45
Copy link
Contributor Author

Are you adding op perms listeners or should I just delete that file myself rn?

@youngcoder45
Copy link
Contributor Author

Bro atleast reply @HyScript7

@HyScript7
Copy link
Owner

Probably delete it. We'll add it sometime else when we actually need debug mode.

@HyScript7 HyScript7 merged commit 112e537 into HyScript7:feat/content_update_1 Dec 8, 2025
@HyScript7
Copy link
Owner

Merged manually in 5745a8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants