Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideRelease housekeeping PR that bumps package versions for @dropout/docs and @dropout/ui, adds/updates their changelogs for the new alpha releases, and deletes the now-consumed .changes entry files. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 4 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="packages/ui/CHANGELOG.md" line_range="7" />
<code_context>
+
+### New Features
+
+- [`32a4d85`](https://github.com/HydroRoll-Team/DropOut/commit/32a4d85af937e4fd882fa671aee8b72878cc564f): Remove all legacy codes in `stores/`. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
+
+### Refactors
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing "legacy codes" to "legacy code" for more natural phrasing.
Here, "code" functions as an uncountable noun, so the singular form is standard English usage.
```suggestion
- [`32a4d85`](https://github.com/HydroRoll-Team/DropOut/commit/32a4d85af937e4fd882fa671aee8b72878cc564f): Remove all legacy code in `stores/`. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
```
</issue_to_address>
### Comment 2
<location path="packages/ui/CHANGELOG.md" line_range="11" />
<code_context>
+
+### Refactors
+
+- [`5b799a1`](https://github.com/HydroRoll-Team/DropOut/commit/5b799a125a970e5e56f29a08b3c86450855fb6c4): Full rewrite instance create with stepper page instead of modal. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
+- [`ffbfce8`](https://github.com/HydroRoll-Team/DropOut/commit/ffbfce895c37e8e8306d426a2e59e73647ed6a86): Refactor game store and rename `HomePage` component. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
+- [`18aceb4`](https://github.com/HydroRoll-Team/DropOut/commit/18aceb4ddf01e964d0b81a4e926e42b72c64e355): Rewrite `ParticleBackground` to modern component design instead of global `window` api call. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
</code_context>
<issue_to_address>
**suggestion (typo):** Sentence structure here is a bit awkward; consider rephrasing for clarity.
For example: "Full rewrite of instance creation with a stepper page instead of a modal."
```suggestion
- [`5b799a1`](https://github.com/HydroRoll-Team/DropOut/commit/5b799a125a970e5e56f29a08b3c86450855fb6c4): Full rewrite of instance creation with a stepper page instead of a modal. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
```
</issue_to_address>
### Comment 3
<location path="packages/ui/CHANGELOG.md" line_range="13" />
<code_context>
+
+- [`5b799a1`](https://github.com/HydroRoll-Team/DropOut/commit/5b799a125a970e5e56f29a08b3c86450855fb6c4): Full rewrite instance create with stepper page instead of modal. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
+- [`ffbfce8`](https://github.com/HydroRoll-Team/DropOut/commit/ffbfce895c37e8e8306d426a2e59e73647ed6a86): Refactor game store and rename `HomePage` component. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
+- [`18aceb4`](https://github.com/HydroRoll-Team/DropOut/commit/18aceb4ddf01e964d0b81a4e926e42b72c64e355): Rewrite `ParticleBackground` to modern component design instead of global `window` api call. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
+- [`97fe504`](https://github.com/HydroRoll-Team/DropOut/commit/97fe5046f68b5e4ee5f750945bcc39a27f5eb37b): Rewrite effect instance nullish checking. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
+
</code_context>
<issue_to_address>
**nitpick (typo):** Tweak wording and capitalization around "modern component design" and "API".
Consider: "Rewrite `ParticleBackground` to a modern component design instead of a global `window` API call."
```suggestion
- [`18aceb4`](https://github.com/HydroRoll-Team/DropOut/commit/18aceb4ddf01e964d0b81a4e926e42b72c64e355): Rewrite `ParticleBackground` to a modern component design instead of a global `window` API call. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409)
```
</issue_to_address>
### Comment 4
<location path="packages/ui/CHANGELOG.md" line_range="18" />
<code_context>
+
+### Chores
+
+- [`ef478b2`](https://github.com/HydroRoll-Team/DropOut/commit/ef478b29605afbd1c3ec88184b64960e8ad01e71): Fix vite config to integrate with Tauri. ([#128](https://github.com/HydroRoll-Team/DropOut/pull/128) by @fu050409)
+
## v0.1.0-alpha.3
</code_context>
<issue_to_address>
**nitpick (typo):** Capitalize "Vite" to match the official project name.
Specifically in this line: `Fix vite config to integrate with Tauri.`
```suggestion
- [`ef478b2`](https://github.com/HydroRoll-Team/DropOut/commit/ef478b29605afbd1c3ec88184b64960e8ad01e71): Fix Vite config to integrate with Tauri. ([#128](https://github.com/HydroRoll-Team/DropOut/pull/128) by @fu050409)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| ### New Features | ||
|
|
||
| - [`32a4d85`](https://github.com/HydroRoll-Team/DropOut/commit/32a4d85af937e4fd882fa671aee8b72878cc564f): Remove all legacy codes in `stores/`. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) |
There was a problem hiding this comment.
suggestion (typo): Consider changing "legacy codes" to "legacy code" for more natural phrasing.
Here, "code" functions as an uncountable noun, so the singular form is standard English usage.
| - [`32a4d85`](https://github.com/HydroRoll-Team/DropOut/commit/32a4d85af937e4fd882fa671aee8b72878cc564f): Remove all legacy codes in `stores/`. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) | |
| - [`32a4d85`](https://github.com/HydroRoll-Team/DropOut/commit/32a4d85af937e4fd882fa671aee8b72878cc564f): Remove all legacy code in `stores/`. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) |
|
|
||
| ### Refactors | ||
|
|
||
| - [`5b799a1`](https://github.com/HydroRoll-Team/DropOut/commit/5b799a125a970e5e56f29a08b3c86450855fb6c4): Full rewrite instance create with stepper page instead of modal. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) |
There was a problem hiding this comment.
suggestion (typo): Sentence structure here is a bit awkward; consider rephrasing for clarity.
For example: "Full rewrite of instance creation with a stepper page instead of a modal."
| - [`5b799a1`](https://github.com/HydroRoll-Team/DropOut/commit/5b799a125a970e5e56f29a08b3c86450855fb6c4): Full rewrite instance create with stepper page instead of modal. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) | |
| - [`5b799a1`](https://github.com/HydroRoll-Team/DropOut/commit/5b799a125a970e5e56f29a08b3c86450855fb6c4): Full rewrite of instance creation with a stepper page instead of a modal. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) |
|
|
||
| - [`5b799a1`](https://github.com/HydroRoll-Team/DropOut/commit/5b799a125a970e5e56f29a08b3c86450855fb6c4): Full rewrite instance create with stepper page instead of modal. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) | ||
| - [`ffbfce8`](https://github.com/HydroRoll-Team/DropOut/commit/ffbfce895c37e8e8306d426a2e59e73647ed6a86): Refactor game store and rename `HomePage` component. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) | ||
| - [`18aceb4`](https://github.com/HydroRoll-Team/DropOut/commit/18aceb4ddf01e964d0b81a4e926e42b72c64e355): Rewrite `ParticleBackground` to modern component design instead of global `window` api call. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) |
There was a problem hiding this comment.
nitpick (typo): Tweak wording and capitalization around "modern component design" and "API".
Consider: "Rewrite ParticleBackground to a modern component design instead of a global window API call."
| - [`18aceb4`](https://github.com/HydroRoll-Team/DropOut/commit/18aceb4ddf01e964d0b81a4e926e42b72c64e355): Rewrite `ParticleBackground` to modern component design instead of global `window` api call. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) | |
| - [`18aceb4`](https://github.com/HydroRoll-Team/DropOut/commit/18aceb4ddf01e964d0b81a4e926e42b72c64e355): Rewrite `ParticleBackground` to a modern component design instead of a global `window` API call. ([#129](https://github.com/HydroRoll-Team/DropOut/pull/129) by @fu050409) |
|
|
||
| ### Chores | ||
|
|
||
| - [`ef478b2`](https://github.com/HydroRoll-Team/DropOut/commit/ef478b29605afbd1c3ec88184b64960e8ad01e71): Fix vite config to integrate with Tauri. ([#128](https://github.com/HydroRoll-Team/DropOut/pull/128) by @fu050409) |
There was a problem hiding this comment.
nitpick (typo): Capitalize "Vite" to match the official project name.
Specifically in this line: Fix vite config to integrate with Tauri.
| - [`ef478b2`](https://github.com/HydroRoll-Team/DropOut/commit/ef478b29605afbd1c3ec88184b64960e8ad01e71): Fix vite config to integrate with Tauri. ([#128](https://github.com/HydroRoll-Team/DropOut/pull/128) by @fu050409) | |
| - [`ef478b2`](https://github.com/HydroRoll-Team/DropOut/commit/ef478b29605afbd1c3ec88184b64960e8ad01e71): Fix Vite config to integrate with Tauri. ([#128](https://github.com/HydroRoll-Team/DropOut/pull/128) by @fu050409) |
99ad4ff to
9a7997e
Compare
Releases
dropout
v0.2.0-alpha.6
Refactors
5b799a1: Full rewrite instance create with stepper page instead of modal. (#129 by @fu050409)ffbfce8: Refactor game store and renameHomePagecomponent. (#129 by @fu050409)18aceb4: RewriteParticleBackgroundto modern component design instead of globalwindowapi call. (#129 by @fu050409)97fe504: Rewrite effect instance nullish checking. (#129 by @fu050409)New Features
32a4d85: Remove all legacy codes instores/. (#129 by @fu050409)Chores
ef478b2: Fix vite config to integrate with Tauri. (#128 by @fu050409)@dropout/docs
v0.1.0-alpha.1
Chores
906a042: Partially apply docs frontend lint fixes (#123 by @fu050409)@dropout/ui
v0.1.0-alpha.4
Chores
ef478b2: Fix vite config to integrate with Tauri. (#128 by @fu050409)Refactors
5b799a1: Full rewrite instance create with stepper page instead of modal. (#129 by @fu050409)ffbfce8: Refactor game store and renameHomePagecomponent. (#129 by @fu050409)18aceb4: RewriteParticleBackgroundto modern component design instead of globalwindowapi call. (#129 by @fu050409)97fe504: Rewrite effect instance nullish checking. (#129 by @fu050409)New Features
32a4d85: Remove all legacy codes instores/. (#129 by @fu050409)