Fix ActionIfIsolated::DoNothing infinite loop when all species are isolated#145
Merged
HyperCodec merged 3 commits intospeciation-rewritefrom Mar 10, 2026
Merged
Fix ActionIfIsolated::DoNothing infinite loop when all species are isolated#145HyperCodec merged 3 commits intospeciation-rewritefrom
HyperCodec merged 3 commits intospeciation-rewritefrom
Conversation
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on the speciation feature rewrite
Fix ActionIfIsolated::DoNothing infinite loop when all species are isolated
Mar 10, 2026
HyperCodec
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ActionIfIsolated::DoNothingis selected and every species has fewer than 2 members, the repopulation loop spins forever —iis never incremented because every iteration hitscontinuewithout producing an offspring.Changes
SpeciatedCrossoverRepopulator::repopulate: Before entering the main loop, checks whether any species has ≥ 2 members whenDoNothingis active. If none do, delegates immediately toinner.repopulateand returns — ensuring the loop is never entered in the degenerate case.DoNothingdoc comment: Documents the fallback behaviour instead of the previous note that a hang was "possible".💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.