feat: Implement AST parser for Soroban#148
Merged
Gbangbolaoluwagbemiga merged 1 commit intoHyperSafeD:mainfrom Feb 26, 2026
Merged
feat: Implement AST parser for Soroban#148Gbangbolaoluwagbemiga merged 1 commit intoHyperSafeD:mainfrom
Gbangbolaoluwagbemiga merged 1 commit intoHyperSafeD:mainfrom
Conversation
Contributor
Author
|
@Gbangbolaoluwagbemiga Please, review PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse Soroban storage types for collision analysis Closes #94
Description
This PR upgrades the static analyzer to understand Soroban storage scopes (
instance,persistent,temporary) when detecting storage key collisions.Before this change, identical keys could be flagged even when used across different storage scopes. Now collisions are reported only when key reuse happens within the same scope.
What changed
Instance,Persistent,Temporary, and fallbackUnknown.(storage_type, key_value).Additional fixes included to satisfy CI
Cargo.lockmerge-conflict markers.-D warningsissues across rule modules (default impls, unused import/variable, simplification).SizeWarningLevelenum.Checklist